REF: handle searchsorted casting within DatetimeLikeArray #30950
Conversation
There was a problem hiding this comment.
Thanks @jbrockmendel . I think changing exception types and error messages should have a whatsnew. also in the case of Exception type, I would regard a change as a breaking change. not sure what others think. Should we have a deprecation for this?
If it were on the Index subclasses I would agree, but for the DTA/TDA/PA (which we dont expect users to use directly) I think we're OK |
https://dev.pandas.io/docs/reference/api/pandas.array.html has examples on how to construct these. |
There was a problem hiding this comment.
I agree with @simonjayhawkins we should have a whatsnew note, but its a very minor change IMHO. otherwise lgtm. ping on green.
I think after this PR you can then share the common code in searchsorted (at least for Index).
Co-Authored-By: Simon Hawkins <[email protected]>
|
ping |
| raise TypeError( | ||
| "searchsorted requires compatible dtype or scalar, " | ||
| f"not {type(value).__name__}" | ||
| ) | ||
| if isinstance(value, Index): |
There was a problem hiding this comment.
can likely move this to the base class an use shared impl with Timedelta (and I guess with DTI?)
|
thanks |
No description provided.