[Client & osu!web] Unsupported file type check and server updates before client finishes up

[rvneXe]

Type

Game behaviour

Bug description

Hi. I tried to submit a beatmap. The client started to upload the whole beatmap first.
I checked the beatmap page immidately and it was changed to WIP (from Graveyard) with some blank difficulties:

After the upload was finished, it returned an error that there's an unsupported file type here, likely called back by the Submissions Server I guess.
The client isn't responding with anything, unless you press "< back" button.

Afterwards, my beatmap page was missing! but present in my profile page

Screenshots or videos

No response

Version

2025.221.0

Logs

compressed-logs.zip

[rvneXe]

Update (UI Problem)

I removed the unsupported file type and this happened. Upload was successful and difficulties are being displayed blank!!!

[rvneXe]

Update (UI Problem)

It's being displayed correctly after uploading again later.
compressed-logs.zip

[bdach]

Just to clarify, was this the first time you attempted to update this beatmap from lazer?

If so then everything is kind of operating as designed, even though I agree that the overall experience is subpar.

I removed the unsupported file type and this happened. Upload was successful and difficulties are being displayed blank!!!

This is a bit of a misdirection. Star ratings are not calculated as part of the initial submission, they're calculated later by a separate process.

I might swap out the big card for a smaller one that doesn't show the list of difficulties to avoid this issue because I don't think I'm changing how this process works.

[rvneXe]

Umm... Yes I guess, I've always updated it via osu!stable. This was first time.

But I think you didn't get my point. I mean the Client should warn the User about unsupported files before even trying to upload it.

And also, the Server shouldn't try to update the beatmap when the integrity of incoming files isn't confirmed yet. This results in a removal of all beatmap files, and "beatmap couldn't be found" page while it's being displayed in the Profile regardless.

[rvneXe]

I mean, the beatmap uploaded successfuly, but got the unsupported file error and the process was stuck there in the client, and I realized that my beatmap page is missing.

[bdach]

I mean the Client should warn the User about unsupported files before even trying to upload it.

Sure I guess.

the Server shouldn't try to update the beatmap when the integrity of incoming files isn't confirmed yet

That wouldn't normally happen for a beatmap that is being updated using lazer. It only happened in this specific case because you were updating a stable beatmap. In new BSS internals this forces a full upload rather than a differential upload. Specifically because there is nothing in the beatmap versioning tables, and new BSS uses that to list the contents of the current package - so new BSS sees pre-existing stable beatmaps as essentially empty. This could be possibly fixed by reverting ppy/osu-server-beatmap-submission@bc41e9a. @peppy interested in your thoughts on that - the tradeoff would be that in production we'd be hitting S3 to list files instead of the database.

[rvneXe]

Mmm I see...

peppy interested in your thoughts on that

I'm not in a place to interfere your decisions, but thanks for your opinion🙏

[bdach]

@rvneXe Actually on second examination, I'm not completely sure what happened here...

Pulling server-side logs, this is shown:

2025-02-21 05:33:56.221	info: osu.Server.BeatmapSubmission.BeatmapSubmissionController[0]
2025-02-21 05:33:56.221	      Reviving beatmap set 2223065
2025-02-21 05:33:56.225	info: osu.Server.BeatmapSubmission.BeatmapSubmissionController[0]
2025-02-21 05:33:56.225	      Deleting beatmaps 4713958, 4815401, 4815402 in set 2223065
2025-02-21 05:33:56.234	info: osu.Server.BeatmapSubmission.BeatmapSubmissionController[0]
2025-02-21 05:33:56.234	      Creating beatmaps 4990079, 4990080, 4990081, 4990082, 4990083 in set 2223065

If this happened, that means that your client must have explicitly not sent the IDs of the old difficulties. If the old difficulties had IDs properly populated in realm and such, they wouldn't get nuked like yours did on upload even if updating a stable beatmap for the first time.

How did you import the beatmap into lazer in the first place? I have a sneaking suspicion something or else might have happened there that broke the chain of identity and dropped difficulty IDs, because if that hadn't happened, nothing would have been nuked even despite the upload failing.

[rvneXe]

How did you import the beatmap into lazer in the first place?

I didn't! This beatmap was created based on lazer editor from the beginning.
I've always been exporting it to .osz and submitting it's updates through stable.

Fortunately I did export a copy version before trying lazer submission, so here it is:

KISS OF LIFE _ Mark Tuan - Superpower (RavenSenpa1) (1).zip (rename to .olz)

[bdach]

KISS OF LIFE _ Mark Tuan - Superpower (RavenSenpa1) (1).zip (rename to .olz)

Why do the .osus inside here all have BeatmapSetID set but not BeatmapID? Did you manually edit these in some way? I suspected that this must have happened but I'm so confused as to how this could happen.

[rvneXe]

I don't know! I haven't touched those .osu files outside of the Editor.

[rvneXe]

@bdach I encountered the same issue again, again there was an unsupported file, and server wiped my beatmap completely (like the first pic of the issue article).
But one other thing after removing the unsupported file, was "Beatmap ID not found in the server" (As I remember the error) and it couldn't upload the beatmap, and again those beatmap diffs were wiped in the website. But I had a backup from the original on-the-server beatmap file for this day, and I compared it to the current not-submitting one in the lazer client, and they had the same IDs.
Then I checked the new IDs of the wiped beatmap using the browser (in the address like: osu.ppy.sh/beatmapsets/SetID/BeatmapID) and the IDs were completely different, comparing to the ones that were assigned before this process.
Sooo.... I guess that server automatically updates (randomizes) all IDs in its database once user catches an error?

[rvneXe]

P.S: I managed to fix this by removing the BeatmapID line in every .osu file

[bdach]

@rvneXe please describe IN DETAIL everything you did before the beatmap got "wiped" including any changes or attempts to submit it from stable