Move prysm specific performance endpoint #15062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he prysm beacon client
…i call to the prysm beacon client
james-prysm
commented
Mar 17, 2025
|
|
||
| func (c prysmChainClient) ValidatorPerformance(ctx context.Context, in *ethpb.ValidatorPerformanceRequest) (*ethpb.ValidatorPerformanceResponse, error) { | ||
| // Check node version for prysm beacon node as it is a custom endpoint for prysm beacon node. | ||
| nodeVersion, err := c.nodeClient.Version(ctx, nil) |
There was a problem hiding this comment.
having this pattern and calling it here really sucks... we should really have this in global state based on what we are initially connected to.
rkapka
reviewed
Mar 18, 2025
Co-authored-by: Radosław Kapka <[email protected]>
rkapka
approved these changes
Mar 18, 2025
rkapka
added a commit
that referenced
this pull request
Mar 19, 2025
* adding in check for non prysm node and moving the prysm endpoint to the prysm beacon client * fixing a bug connecting to a non prysm client and moving the prysm api call to the prysm beacon client * changelog * fixing linting * Update validator/client/metrics.go Co-authored-by: Radosław Kapka <[email protected]> --------- Co-authored-by: Radosław Kapka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
The validator client when running in REST API mode prints a 404 error which is cosmetic when connected to a non prysm beacon node. this is because the code is calling the /prysm/validators/performance endpoint which is prysm specific. this PR moves the endpoint to the prysm specific client internally and does a check whether it's a prysm beacon node so it will no longer print the 404 error
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements