Fix following stub imports in daemon when using --follow-imports=skip #10092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think that it has worked properly before anyway.
ilevkivskyi
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find added stubs in daemon when using
--follow-imports=skip. Previouslyit was often necessary to restart the daemon to find new stubs. This was
inconsistent, as the initial build did follow imports to stubs but incremental
runs didn't (at least reliably).
Add an optimization that avoids checking modules within top-level packages
that clearly don't exist.
This still can regress performance in large codebases somewhat significantly.
I'll create follow-up PRs that make the regression less bad.
Also mark
follow_imports_for_stubsas unsupported in the daemon. I don'tthink that it worked reliably before, and now it works even less well.