[mypyc] Faster set creation with generator expression #10261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Have you benchmarked this against master? (If not, no worries, I can do some quick benchmarking tomorrow.) |
Not yet. |
97littleleaf11
commented
Mar 30, 2021
| @@ -143,6 +143,9 @@ def translate_safe_generator_call( | |||
| val = tuple_from_generator_helper(builder, expr.args[0]) | |||
| if val is not None: | |||
| return val | |||
| if callee.fullname == "builtins.set": | |||
| return translate_set_comprehension(builder, expr.args[0]) | |||
|
|
|||
There was a problem hiding this comment.
Maybe I should move builtins.set to a new specialize function ?
There was a problem hiding this comment.
That sounds reasonable, since the implementation isn't sharing much with the other cases.
|
I measured the performance and now the speed of calling |
JukkaL
approved these changes
Mar 31, 2021
sthagen
added a commit
to sthagen/python-mypy
that referenced
this pull request
Apr 2, 2021
[mypyc] Faster set creation with generator expression (python#10261)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes mypyc/mypyc#771 and #9707
Changes:
tranform_set_comprehensiontotranslate_set_comprehensionset(f(x) for x in it)no longer uses list comprehension (#771) #9707 (comment))Test Plan
Both generated IR test and functional test:
listtupledictrange)