[mypyc] Remangle names produced by allow-redefinition #11175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mypyc/mypyc#702 by replacing "'" with "__redef__", although this assumes nothing else will ever use demangling for now. Only locals need any fix; a run testcase was added to verify that it works already for globals, and since the fix for locals is on the ir level only an ir testcase is added.
JukkaL
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes mypyc/mypyc#702 by replacing "'" with "redef",
although this assumes nothing else will ever use demangling
for now.
Test Plan
Only locals need any fix; a run testcase was added to verify
that it works already for globals, and since the fix for locals
is on the ir level only an ir testcase is added.