fix: warn unused ignores when not all specified error codes are used #11178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: core (https://github.com/home-assistant/core.git)
- homeassistant/components/http/__init__.py:299: error: unused "type: ignore" comment
+ homeassistant/components/http/__init__.py:299: error: unused "type: ignore[arg-type, misc]" comment
ignite (https://github.com/pytorch/ignite)
- ignite/engine/deterministic.py:255: error: unused "type: ignore" comment
+ ignite/engine/deterministic.py:255: error: unused "type: ignore[arg-type, attr-defined]" comment
- ignite/engine/deterministic.py:260: error: unused "type: ignore" comment
+ ignite/engine/deterministic.py:260: error: unused "type: ignore[attr-defined, union-attr]" comment
pandas (https://github.com/pandas-dev/pandas.git)
- pandas/core/arrays/_mixins.py:238: error: unused "type: ignore" comment
+ pandas/core/arrays/_mixins.py:238: error: unused "type: ignore[assignment, type-var]" comment
- pandas/core/arrays/datetimelike.py:497: error: unused "type: ignore" comment
+ pandas/core/arrays/datetimelike.py:497: error: unused "type: ignore[arg-type, return-value]" comment
- pandas/core/arrays/string_arrow.py:739: error: unused "type: ignore" comment
+ pandas/core/arrays/string_arrow.py:739: error: unused "type: ignore[arg-type, type-var]" comment
- pandas/core/arrays/string_.py:551: error: unused "type: ignore" comment
+ pandas/core/arrays/string_.py:551: error: unused "type: ignore[arg-type, type-var]" comment
- pandas/io/parsers/base_parser.py:988: error: unused "type: ignore" comment
+ pandas/io/parsers/base_parser.py:988: error: unused "type: ignore[arg-type, return-value]" comment
- pandas/core/reshape/merge.py:2153: error: unused "type: ignore" comment
+ pandas/core/reshape/merge.py:2153: error: unused "type: ignore[assignment, union-attr]" comment
aiohttp (https://github.com/aio-libs/aiohttp.git)
+ aiohttp/client.py:1063: error: unused "type: ignore[arg-type]" comment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11157
For
--warn-unused-ignored, currentlyErrors.used_ignored_lineskeeps track of only the line numbers without error codes when errors appeares on the line with# type: ignoreor# type: ignore[...].This PR changes
used_ignored_linesso that it also keeps track of error codes and that information used ingenerate_unused_ignore_errorsto show an error message likeunused "type: ignore[attr-defined]" comment.I'm very new to mypy code base and one thing I'm not so confident about my change is that I might be using
MISCerror codes in an unintended way.Please let me know if this approach is correct and I appreciate any feedback.
Thank for the review!
Test Plan
There are some tests using
--warn-unused-ignores, but this PR didn't change the result of those tests. So, I added a few test namedtestErrorCodeWarnUnusedIgnoresintest-data/unit/check-errorcodes.testwhich have different behavior between this PR and current master.