Replace _t_complexity_ with build_call_graph in comparison gates
#1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_t_complexity_ with build_call_graph in comparison gates
|
@tanujkhattar this PR becomes obsolete once I merge my upcoming PR that reimplements all comparison gates + adds missing comparison gates. I will send the PR today. |
|
I think this is a fairly straightforward change, so lets merge this and then I will lookout for your PR with the revamp? In case we are not able to merge your PR in time for the release; this would be a good temporary solution to unblock other upgrades. |
NoureldinYosri
approved these changes
May 29, 2024
|
this broke the |
|
Yeah, I'll send a fix soon. Realized it when implementing symbolic state prep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1010
Helps support symbolics and better resource counting for comparison gates.
Edit: Also updated
LessThanEqualgate.