Skip to content

Add AutoPartition and BloqBuilder.add_and_partition to fit bloqs together whose registers don't quite match #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 27, 2024
Merged

Add AutoPartition and BloqBuilder.add_and_partition to fit bloqs together whose registers don't quite match #1086

merged 15 commits into from
Jun 27, 2024

Conversation

charlesyuan314
Copy link
Contributor

@charlesyuan314 charlesyuan314 commented Jun 19, 2024 •
edited
Loading

Completes the implementation of the wrapper bloq introduced in #789 and adds an alternative interface to it as a BloqBuilder utility method.

@charlesyuan314
Copy link
Contributor Author

FYI @fdmalone

@mpharrigan
Copy link
Collaborator

One of the motivations in the linked PR was to clean up the circuit diagrams by hiding the partition/unpartition pairs behind a level of decomposition. Does this still do that?

@fdmalone
Copy link
Collaborator

Awesome, I was thinking the AutoPartition would be a bloq by itself (like Split and Join) and then the bloq builder would use this bloq (similar to split and join), but this works too.

@charlesyuan314 charlesyuan314 changed the title Add BloqBuilder.add_and_partition to fit bloqs together whose registers don't quite match Add AutoPartition and BloqBuilder.add_and_partition to fit bloqs together whose registers don't quite match Jun 21, 2024
@charlesyuan314
Copy link
Contributor Author

I made AutoPartition be its own bloq again and added tests and documentation.

@charlesyuan314 charlesyuan314 marked this pull request as ready for review June 21, 2024 01:01
mpharrigan
mpharrigan reviewed Jun 21, 2024
View reviewed changes
mpharrigan
mpharrigan reviewed Jun 21, 2024
View reviewed changes
mpharrigan
mpharrigan reviewed Jun 21, 2024
View reviewed changes
mpharrigan
mpharrigan reviewed Jun 21, 2024
View reviewed changes
mpharrigan
mpharrigan reviewed Jun 21, 2024
View reviewed changes
mpharrigan
mpharrigan reviewed Jun 21, 2024
View reviewed changes
@charlesyuan314 charlesyuan314 mentioned this pull request Jun 21, 2024
Closed
mpharrigan
mpharrigan reviewed Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very comprehensive! Thanks for adding docs as well. LGTM modulo wording fixes on the flag-for-one-sidedness

@charlesyuan314
Copy link
Contributor Author

@mpharrigan PTAL!

mpharrigan
mpharrigan approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweeeeeeeeet

@mpharrigan mpharrigan enabled auto-merge (squash) June 27, 2024 17:19
@mpharrigan mpharrigan merged commit c6aa419 into quantumlib:main Jun 27, 2024
7 checks passed
@charlesyuan314 charlesyuan314 deleted the add_and_partition branch July 30, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpharrigan mpharrigan mpharrigan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlesyuan314 @mpharrigan @fdmalone