Revamp ChebyshevPolynomial
#1213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChebyshevPolynomial
to the modernBlockEncoding
interface by changing the base class, attribute type, and signature.ChebyshevPolynomial
only works correctly with block encodingsChebyshevPolynomial
correct for use with non-Hermitian block encodingsThe last change involves invoking$\mathcal{B}[A]^\dagger$ . Most of our block encodings are not Hermitian, making this necessary for correctness. The total number of invocations of $\mathcal{B}[A]$ and its adjoint remains equal to the specified order of the Chebyshev polynomial.
There are no existing users of
ChebyshevPolynomial
to update.