GraphvizCallGraph.from_bloq
#1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanujkhattar
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new factory method
GraphvizCallGraph.from_bloqthat will set up a nice call graph for youQECGatesCostandQubitCountSome drive-by improvements to handling symbolics in
GateCounts.I've also modified the
show_call_graphconvenience function to dispatch based on the input type: If it's a graph (like before) it will use the previous code path (which will eventually be deprecated when I go through and make sure all the bloqs have good-enough__str__values). If a bloq is provided, it will use the new functionality. Watching some new users: It seems like people expected to be able to pass a bloq toshow_call_graphand have it show the call graph.