Skip to content

n_qubits for symbolic signature #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

mpharrigan
Copy link
Collaborator

@mpharrigan mpharrigan commented Aug 19, 2024

Use sympy-symbolic-supporting smax instead of max for Signature.n_Qubits.

Fixes #1298

Does not fix and therefore keeps open: #1261

@tanujkhattar
Copy link
Collaborator

I think github is not able to parse "Does not" from the second line; and merging this PR would close #1261 as well. Please update the description.

@mpharrigan
Copy link
Collaborator Author

omg whoops

@mpharrigan mpharrigan merged commit 036383e into quantumlib:main Aug 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show_call_graph(bloq) doesn't work for bloqs with symbolic signature due to qubit count computation raising an error.
3 participants