Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final part of #1251
This PR removes the legacy
_t_complexity_
override from all bloqs. These were already redundant: during development of previous PRs I had removed use of these anyways. Those PRs did careful accounting of allbloq_example
and unit test t complexity values and made sure they matched theQECGatesCost
values (with some small, contained legacy shims). This PR shows that off!See my inline comments, but I left in a
getattrs
-based shim so that the_t_complexity_
override will still be used ifQECGatesCost()
is in legacy mode. The only thing left in qualtran that uses it is a specific unit test I added to test it.