Add my_static_costs override for accurate QubitCounts for qrom bloqs
#1414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
approved these changes
Sep 23, 2024
|
for testing sympy equality, they recommend subtracting the two expressions and asserting that it simplifies to zero. using |
tanujkhattar
commented
Sep 24, 2024
| @@ -183,11 +183,11 @@ def test_dirtyoutofplacemontgomerymodmul_symbolic_cost(uncompute): | |||
|
|
|||
| # Litinski 2023 https://arxiv.org/abs/2306.08585 | |||
| # Figure/Table 8. Lists modular multiplication as 2.25n^2+9n toffoli. | |||
| # The following formula is 2.25n^2+8.25n-1 written with rationals because sympy comparison fails with floats. | |||
| # The following formula is 2.25n^2+7.25n-1 written with rationals because sympy comparison fails with floats. | |||
There was a problem hiding this comment.
@NoureldinYosri Can you please verify that this change is expected? I've simply updated the test assuming the constant factor reduction in qroam uncomputation is translating into reduced constant factors here.
There was a problem hiding this comment.
yes, the constant factor from qroam gets multiplied by
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for correctly counting number of qubits for cases when the exact data is not available, and hence it's not possible to create the circuit decomposition.