Skip to content

Implement CtrlScaleModAdd and CModAddK bloqs for Modular Exponentiation #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 17, 2024

Conversation

fpapa250
Copy link
Contributor

@fpapa250 fpapa250 commented Oct 2, 2024

Implements CtrlScaleModAdd and CModAddK bloqs. Also fixes a typechecking error with IntEffect (found thanks to mypy). For some reason it has a serialization error on CModAddK autobloqtester for split/joins even with the ignore_split_join generalizer.

@fpapa250 fpapa250 marked this pull request as ready for review October 2, 2024 18:12
@mpharrigan mpharrigan self-requested a review October 4, 2024 20:49
Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass

Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some wording confusion in the docstrings

Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some final nits, then lgtm

@mpharrigan mpharrigan enabled auto-merge (squash) October 17, 2024 23:11
@mpharrigan mpharrigan merged commit 0220df2 into quantumlib:main Oct 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants