-
Notifications
You must be signed in to change notification settings - Fork 71
Implement CtrlScaleModAdd and CModAddK bloqs for Modular Exponentiation #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some wording confusion in the docstrings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some final nits, then lgtm
Implements CtrlScaleModAdd and CModAddK bloqs. Also fixes a typechecking error with IntEffect (found thanks to mypy). For some reason it has a serialization error on CModAddK autobloqtester for split/joins even with the ignore_split_join generalizer.