Skip to content

Default Bloq.get_ctrl_system: Use And ladder to reduce multiple controls to single control #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 17, 2024
Merged

Default Bloq.get_ctrl_system: Use And ladder to reduce multiple controls to single control #1456

merged 5 commits into from
Oct 17, 2024

Conversation

anurudhp
Copy link
Contributor

@anurudhp anurudhp commented Oct 9, 2024 •
edited
Loading

use ControlledViaAnd for any non-trivial control spec, to reduce to an And ladder and a singly controlled bloq.

This could resolve #1452

@anurudhp anurudhp mentioned this pull request Oct 9, 2024
Merged
@mpharrigan mpharrigan mentioned this pull request Oct 10, 2024
Closed
mpharrigan
mpharrigan approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big change, but I think a good one. Others: speak now or hold your peace!

@mpharrigan mpharrigan enabled auto-merge (squash) October 17, 2024 23:11
@mpharrigan mpharrigan merged commit 3117a84 into quantumlib:main Oct 17, 2024
8 checks passed
@anurudhp anurudhp deleted the 2024/10/09-default-ctrl branch October 18, 2024 02:57
This was referenced Oct 28, 2024
Draft
Closed
@anurudhp anurudhp mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpharrigan mpharrigan mpharrigan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make .controlled() work more robustly
2 participants
@anurudhp @mpharrigan