-
Notifications
You must be signed in to change notification settings - Fork 72
Deprecate MultiControlPauli
#1492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mpharrigan
merged 5 commits into
quantumlib:main
from
anurudhp:2024/11/09-deprecate-mcpauli
Nov 27, 2024
Merged
Deprecate MultiControlPauli
#1492
mpharrigan
merged 5 commits into
quantumlib:main
from
anurudhp:2024/11/09-deprecate-mcpauli
Nov 27, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d8b9c6
to
51013cf
Compare
@mpharrigan ptal |
…r `MultiControlZ` instead
51013cf
to
dab427a
Compare
usually, we'd keep the name as-is and use the |
mpharrigan
approved these changes
Nov 27, 2024
NoureldinYosri
pushed a commit
to NoureldinYosri/Qualtran
that referenced
this pull request
Jan 28, 2025
* make `MultiControlPauli` a hidden class, always use `MultiControlX` or `MultiControlZ` instead * add `DeprecationWarning` instead of renaming bloq --------- Co-authored-by: Tanuj Khattar <[email protected]>
This was referenced Jan 29, 2025
This was referenced Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All users now use the derived
MultiControlX
orMultiControlZ
instead. I've kept the class around as it has a simpler interface (list of control bits instead of a CtrlSpec), and also supports zero controls (#679).Fixes #914