Make And a leaf bloq
#1513
Merged
Make And a leaf bloq
#1513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpharrigan @fdmalone ptal! |
mpharrigan
approved these changes
Dec 20, 2024
| @@ -280,10 +279,10 @@ def build_call_graph(self, ssa: 'SympySymbolAllocator') -> 'BloqCountDictT': | |||
| in_prep_dag: 1, # in_prep_l^dag | |||
| rot: 1, # rotate into system basis listing 4 pg 54 | |||
| # apply CCZ first then CCCZ, the cost is 1 + 2 Toffolis (step 4e, and 7) | |||
| Toffoli(): 1, | |||
| ApplyControlledZs(cvs=(1, 1), bitsize=5): 1, | |||
There was a problem hiding this comment.
was this incorrect before? I see the change makes it match the comment
There was a problem hiding this comment.
The previous test was only checking the sigma for the call graph. I updated it to check for equivalent bloq counts, which flagged this inconsistency.
NoureldinYosri
pushed a commit
to NoureldinYosri/Qualtran
that referenced
this pull request
Jan 28, 2025
* make `And` a leaf bloq * cleanup `And` * fix `DoubleFactorizationOneBody` call graph * fix `t_counts_from_sigma` (deprecated but used in flame graph)
This was referenced Jan 29, 2025
This was referenced Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1346
also removes the only use of big O in call graph #1368
FLAG_AND_IS_LEAF=Trueand fixes all testsAndbloq codet_counts_from_sigmato explicitly countAnds