-
Notifications
You must be signed in to change notification settings - Fork 71
Add bloq for Binary Polynomial Multiplication #1554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
approved these changes
Feb 14, 2025
This was referenced Feb 15, 2025
This was referenced Mar 5, 2025
NoureldinYosri
added a commit
that referenced
this pull request
Mar 31, 2025
This is the final PR in the series #1554, #1533, and #1516. These PRs implemented the GF($2^n$) multiplication construction from https://arxiv.org/abs/1910.02849v2 which has a toffoli complexity of $n^{\log_2{3}}$
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bloqs$n^{\log_2{3}}$ . The construction of each recursively calls the other.
BinaryPolynomialMultiplication
andMultiplyPolyByOnePlusXk
implement karatsuba's algorithm for binary polynomial multiplication with toffoli count ofThese two bloqs are algorithms 3 and 2 from https://arxiv.org/pdf/1910.02849v2 respectively.
In a final PR, I will implement algorithm 4 which implements galois multiplication in GF($2^n$ ) $\mod m(x)$ where $m(x)$ is an irreducible binary polynomial.