Skip to content

Add explicit versions and timeouts to GHA workflows #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Mar 3, 2025

This updates the GitHub Actions workflows to conform to some Google requirements and best practices:

  • pin versions of GitHub Actions to commit SHAs
  • pin versions of runners instead of using *-latest
  • set default permissions for workflow
  • set timeouts on jobs, to prevent running for 6 hrs (the default) in case of hangs or loops

This also fixes the following Scorecard security warnings:

This updates the GitHub Actions workflows to conform to some Google
requirements and best practices:

- pin versions of GitHub Actions to commit SHAs
- pin versions of runners instead of using *-latest
- set default permissions for workflow
- set timeouts on jobs, to prevent running for 6 hrs (the default) in
  case of hangs or loops
@mhucka mhucka requested a review from mpharrigan March 3, 2025 16:04
@mhucka mhucka merged commit 458705c into quantumlib:main Mar 3, 2025
8 checks passed
@mhucka mhucka deleted the mh-ci-best-practices branch March 7, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants