Do minor updates to dot files and add license headers #1598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Add license header - Add line length setting - Reduce allowed raw HTML elements This version matches the current common version of the file I've been adding to the Quantumlib repos.
Changes: - Add license header - Add more settings - Adjust settings to match (apparent) Qualtran project conventions Except for the changed settings, this version of the file matches the current common version of the file I've been adding to the Quantumlib repos.
mpharrigan
approved these changes
Mar 19, 2025
After more discussion, the conclusion is that despite the issues with `max_line_length`, it is handled as expected in the editors that many people have been using.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discovering this week that Google's requirements for license headers are not what I originally thought (tl;dr: they're actually needed everywhere), I'm going around and adding them to files where I failed to put them before.
Along with that, for files like
.editorconfig, I'm updating them slightly to match the conclusions from recent discussions.