-
Notifications
You must be signed in to change notification settings - Fork 72
Introduce types to t_complexity
#835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce types to t_complexity
#835
Conversation
t_complexity
3839e7c
to
0f6d91f
Compare
0f6d91f
to
67109b3
Compare
@tanujkhattar fyi, I still want to do this. Current status
Getting things completely bloq-y will enable a seamless transition to the |
160c806
to
f34659b
Compare
This is ready for preliminary review, although I will continue testing things on my side. |
Ok, I called
|
These ones used to cause errors and still do
|
@tanujkhattar can you ptal |
Everything is a bloq now, so we can indicate that with types in the
t_complexity
function. It will now duck-type for bloqs. There are some tests that still want to find the t complexity of things that contain bloqs, so I added a_compat
version. I moved all the places where you literally need to get the TComplexity to a gate to explicit calls to_from_directly_countable
(now with a_cirq
suffix) so its more explicit where these values are coming from.Depends on #825