Remove inappropriate @boundscheck

[barucden]

When running julia with --check-bounds=no, the package fails to precompile. The reason is that compiler elides @boundschecks, which in this case removes buffer reallocation. I believe that's unwanted.

Issue was reported on Discourse by 0samuraiE.

[nhz2]

Does this have any impact on performance when Julia is run normally?

Particularly for code using:

JSON3.jl/src/write.jl

Line 261 in fb220e5

@inbounds @writechar bytes[i]

JSON3.jl/src/write.jl

Line 276 in fb220e5

@inbounds @writechar bytes[i]

JSON3.jl/src/write.jl

Line 344 in fb220e5

@inbounds @writechar '"'

JSON3.jl/src/write.jl

Line 359 in fb220e5

@inbounds @writechar '"'

[barucden]

Does this have any impact on performance when Julia is run normally?

Can you suggest a representative benchmark I could run? Is it enough to just print the JSON representation of bunch of numbers?

I tried the following:

using JSON3, BenchmarkTools

struct T
    a::Int
    b::Float64
    c::String
    null::Nothing
    maybe::Union{Int, Nothing}
end

t = T(1232423567890, 12.345678901234, "ABCDEFGHIJKLMNOPQRSTUVXYZ", nothing, 1234567890123)
@btime JSON3.write(IOBuffer(), $t)

I observe the following measurements:

  422.397 ns (15 allocations: 992 bytes) # with @boundcheck
  424.176 ns (15 allocations: 992 bytes) # without @boundscheck

---

Should I also update the CI action versions so that the tests run?

[barucden]

Action versions updated.

[barucden]

I rebased to the branch containing Nathan's fixes from #312. So this PR should be merged after #312.