[Tooltip] Remove type="button"

[jjenzz]

Closes #1010
Closes #993

I haven't done this for our other components that add type="button" since I don't believe we have had reports regarding those yet. Not sure what thoughts are here though?

[benoitgrelard]

I haven't done this for our other components that add type="button" since I don't believe we have had reports regarding those yet. Not sure what thoughts are here though?

I have been wondering exactly the same thing. Trying to rationalise it, I feel like Tooltip.Trigger is the only trigger whose functionality isn't entirely relying on a click/pointerdown action. That makes me think that all the other triggers where we do type="button" have no business being replaced with other HTML elements as it wouldn't really be semantic anymore.

All that to say I think we're ok to do it just here for now and see what comes out on others if anything.

[bel0v]

Hey guys, found this PR when fixing a tooltip submitting a form. Just wondering — the issues mentioned seem to have a problem with an asChild usage of the Trigger. If asChild is not provided, the tooltip renders a button. So I didn't quite get it why this PR just removed type=button in all cases... Is there a case when a tooltip trigger as submit button is desired? 🤔

[benoitgrelard]

This PR removed type=button because a tooltip trigger can be more than a button, it can sometimes be on a link, or even an input of many types.

[bel0v]

@benoitgrelard I get that, but that seems to be only the asChild use case. Otherwise the trigger renders a button, but now that button is of type submit.

[Roanmh]

I just ran into this too. I wonder if the type=button parameter could be provided conditionally when the asChild property is false so the type property is guaranteed to be only be applied to a button component.