Skip to content

React 18 #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 14, 2022
Merged

React 18 #1329

merged 6 commits into from
Apr 14, 2022

Conversation

benoitgrelard
Copy link
Contributor

No description provided.

@benoitgrelard benoitgrelard marked this pull request as ready for review April 13, 2022 18:13
Copy link
Contributor Author

@benoitgrelard benoitgrelard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done a pass on it @andy-hook and it seems all good to go for me

Copy link
Contributor

@andy-hook andy-hook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, should we remove Polymorphic entirely in a separate change?

@benoitgrelard
Copy link
Contributor Author

Yep, I was going to do this straight after! You're reading my mind 🙂

@benoitgrelard benoitgrelard merged commit 7b89539 into main Apr 14, 2022
@benoitgrelard benoitgrelard deleted the react-18 branch April 14, 2022 11:17
@benoitgrelard
Copy link
Contributor Author

#1331

@apoco
Copy link

apoco commented Jul 9, 2022

Are there plans to publish this fix soon?

@benoitgrelard
Copy link
Contributor Author

Hi @apoco, yes it is planned to be released in the next release in the coming week or two.

luisorbaiceta pushed a commit to luisorbaiceta/primitives that referenced this pull request Jul 21, 2022
* Upgrade deps and types

* Testing CI

* Update test setup

* Add typechecking to CI

* Revert portal fixes

* Versions
@zenorocha
Copy link

@apoco it's now available in the v1.0 release :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants