Skip to content

[Select] Fix positioning issue when few items are present #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2022
Merged

[Select] Fix positioning issue when few items are present #1355

merged 1 commit into from
Apr 29, 2022

Conversation

benoitgrelard
Copy link
Contributor

Closes #1350

We make sure our heuristic doesn't apply too eagerly when there are less items.

Note: Whilst testing for this, I noticed a bunch of alignment stuff is broken :( probably due to the React 18 upgrade given nobody has reported yet… I'm gonna add a separate issue to track and will take a look.

@benoitgrelard benoitgrelard mentioned this pull request Apr 29, 2022
Closed
@benoitgrelard benoitgrelard merged commit f20f6f1 into main Apr 29, 2022
@benoitgrelard benoitgrelard deleted the 1350-select-few-items branch April 29, 2022 11:23
@benoitgrelard benoitgrelard mentioned this pull request Apr 29, 2022
Merged
luisorbaiceta pushed a commit to luisorbaiceta/primitives that referenced this pull request Jul 21, 2022
@benoitgrelard @luisorbaiceta
[Select] Fix positioning issue when few items are present (radix-ui#1355
1c27896 
)

Closes radix-ui#1350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-hook andy-hook andy-hook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Select] at page bottom with few items shows content at wrong position
2 participants
@benoitgrelard @andy-hook