Skip to content

[Menu][Select] Add data-highlighted attribute #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2022
Merged

[Menu][Select] Add data-highlighted attribute #1388

merged 2 commits into from
May 11, 2022

Conversation

benoitgrelard
Copy link
Contributor

Closes #1289

Note: I also renamed data-state="active|inactive" to data-state="checked|unchecked" in Select to avoid confusion and bring inline with menus.

@benoitgrelard benoitgrelard requested a review from andy-hook as a code owner May 11, 2022 11:05
@benoitgrelard benoitgrelard changed the title [Menu][Select] Add data-active attribute [Menu][Select] Add data-highlighted attribute May 11, 2022
@benoitgrelard benoitgrelard merged commit 30dd35b into main May 11, 2022
@benoitgrelard benoitgrelard deleted the 1289-data-active branch May 11, 2022 14:32
@benoitgrelard benoitgrelard mentioned this pull request May 13, 2022
Merged
luisorbaiceta pushed a commit to luisorbaiceta/primitives that referenced this pull request Jul 21, 2022
@benoitgrelard @luisorbaiceta
[Menu][Select] Add data-highlighted attribute (radix-ui#1388)
a896e3b 
* [Menu][Select] Add `data-active` attribute

Closes radix-ui#1289

* Rename active to highlighted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-hook andy-hook andy-hook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Menu] Introduce new data-active state attribute
2 participants
@benoitgrelard @andy-hook