Skip to content

[AlertDialog][ContextMenu][Dialog][DropdownMenu][Popover][Select] Remove allowPinchZoom prop #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

benoitgrelard
Copy link
Contributor

  • allowPinchZoom was false by default, which is by default an accessibility issue.
  • It also means if users want it back, it's impossible to bring back without the extra prop
  • after experimenting with our own remove scroll ideas during hack week, we concluded pinch zooming should be allowed by default and that if users want to disallow that, they can do it themselves, so we're removing the prop and hardcoding to true for now so we don't create an extra breaking change for it after v1.

@benoitgrelard benoitgrelard requested a review from andy-hook as a code owner July 7, 2022 11:51
@benoitgrelard benoitgrelard merged commit 81d1374 into main Jul 7, 2022
@benoitgrelard benoitgrelard deleted the remove-allow-pinch-zoom-prop branch July 7, 2022 15:04
luisorbaiceta pushed a commit to luisorbaiceta/primitives that referenced this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants