[Popper] Use floating-ui
#1531
Merged
[Popper] Use floating-ui
#1531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitgrelard
commented
Jul 18, 2022
cfdd4ae to
558d2b2
Compare
andy-hook
reviewed
Jul 19, 2022
andy-hook
approved these changes
Jul 19, 2022
luisorbaiceta
pushed a commit
to luisorbaiceta/primitives
that referenced
this pull request
Jul 21, 2022
* [Popper] Use `floating-ui` * Re-integrate collision props * Align stories * Align for chromatic * More chromatic bits * Update DropdownMenu.stories.tsx * Restore Popper stories * Cater for PopperContent in Portal positioning issues * Hide arrow automatically * Add Popper chromatic story * Update Popper.stories.tsx * Delete old `core/popper` package * Delete usage of Arrow `offset` prop * Update 07c2bf00.yml * Default to `fixed` strategy * Expose `arrowPadding` prop * No need for Portal on sub in ContextMenu and DropdownMenu * Fix typeahead scoping in submenus * Add comments * PR feedback * Expose more configuration * Fix story for chromatic * Add padding to chromatic stories * Add delay to chromatic stories * Fix chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR: #1540
Supersedes #1516
Fixes #370
Fixes #557
Fixes #740
Fixes #781
Fixes #800
Fixes #1445
Fixes #1464
Others potentially linked to investigate:
#791 — explore this
#945 — may be doable now with use of mainAxis shift, but not sure it's worth it, probably needs a diff pattern
#1087 — linked to #791
Arrowoffsetprop is goneContentcollisionToleranceprop is renamed tocollisionPaddingand acceptnumber | PaddingContentarrowPaddingprop is newContentstickyprop is newContenthideWhenDetachedprop is newPortalpart around submenu contents (inDropdownMenuandContextMenu)mainand delete references tocore/popperin version files (only 1 I think)