Skip to content

[Toast] Add onPause and onResume #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2022
Merged

[Toast] Add onPause and onResume #1669

merged 2 commits into from
Sep 20, 2022

Conversation

andy-hook
Copy link
Contributor

@andy-hook andy-hook commented Sep 16, 2022 •
edited
Loading

builds on #1668
closes #1453
supercedes #1477

@andy-hook andy-hook marked this pull request as ready for review September 16, 2022 15:47
@andy-hook andy-hook mentioned this pull request Sep 16, 2022
Closed
benoitgrelard
benoitgrelard approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@benoitgrelard benoitgrelard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a small weirdness when creating a bunch of toasts, then tabbing into them, then hovering in/out, they close abruptly.

Otherwise code looks great.

@andy-hook
Copy link
Contributor Author

I noticed a small weirdness when creating a bunch of toasts, then tabbing into them, then hovering in/out, they close abruptly.

Confirmed as an existing issue on main, I'll raise a separate fix for it.

Base automatically changed from fix-toast-dom-ref to main September 20, 2022 12:43
@andy-hook andy-hook merged commit 304cc8c into main Sep 20, 2022
@andy-hook andy-hook deleted the toast-pause-resume branch September 20, 2022 13:05
@andy-hook andy-hook mentioned this pull request Sep 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitgrelard benoitgrelard benoitgrelard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Toast] Add onPause / onResume props
2 participants
@andy-hook @benoitgrelard