[Toast] Fix timer issues #1682
Merged
[Toast] Fix timer issues #1682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-hook
commented
Sep 22, 2022
b2bd9f3 to
d473d85
Compare
andy-hook
commented
Sep 26, 2022
packages/react/toast/src/Toast.tsx
Outdated
|
|
||
| const handleFocusOutResume = (event: FocusEvent) => { | ||
| // Only resume when focus moves out of the wrapper | ||
| if (!wrapper.contains(event.relatedTarget as HTMLElement)) { |
There was a problem hiding this comment.
We still need to handle for this as focusout / focusin will fire while tabbing within wrapper and we don't want to flip the flag until we're back outside.
|
I think I spotted another issue: CleanShot.2022-09-26.at.13.49.05.mp4Leave should only trigger resume if focus isn't inside right? |
Good spot, tweaked a little. Let me know how that feels. |
benoitgrelard
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address timer issues mentioned in #1669 (comment)
The underlying issue is that the pause handling doesn't account for multiple calls in succession. Because we're now exposing
onPauseandonResumeit made more sense to address the issue at source with the duplicate events being fired.@benoitgrelard might be easier to hop on a call to go over this.