[Label] Use native label
#1686
Merged
[Label] Use native label
#1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitgrelard
commented
Sep 26, 2022
| "@radix-ui/react-dropdown-menu": patch | ||
| "@radix-ui/react-focus-scope": patch | ||
| "@radix-ui/react-hover-card": patch | ||
| "@radix-ui/react-label": major |
There was a problem hiding this comment.
one major in a sea of patches
benoitgrelard
commented
Sep 26, 2022
Comment on lines
-10
to
-30
| export const AutoGeneratedId = () => ( | ||
| <Label className={rootClass()}> | ||
| Label <Control /> | ||
| </Label> | ||
| ); | ||
|
|
||
| export const SuppliedId = () => ( | ||
| <Label id="test" className={rootClass()}> | ||
| Label <Control /> | ||
| </Label> | ||
| ); | ||
|
|
||
| export const WithHtmlFor = () => ( | ||
| <> | ||
| <Label htmlFor="test" className={rootClass()}> | ||
| This should add an `aria-labelledby` to the control | ||
| </Label> | ||
| <Control id="test" /> | ||
| </> | ||
| ); | ||
|
|
There was a problem hiding this comment.
Removed these now irrelevant stories.
Comment on lines
-81
to
-101
| export const Chromatic = () => ( | ||
| <> | ||
| <h1>Auto generated id</h1> | ||
| <Label className={chromaticRootClass()}> | ||
| <Control /> | ||
| </Label> | ||
|
|
||
| <h1>Supplied id</h1> | ||
| <Label id="one" className={chromaticRootClass()}> | ||
| <Control /> | ||
| </Label> | ||
|
|
||
| <h1>With htmlFor</h1> | ||
| <Label htmlFor="two" className={chromaticRootClass()}> | ||
| {' '} | ||
| This should add an `aria-labelledby` to the control | ||
| </Label> | ||
| <Control id="two" /> | ||
| </> | ||
| ); | ||
| Chromatic.parameters = { chromatic: { disable: false } }; |
There was a problem hiding this comment.
Not much we now can/need to test visually.
andy-hook
approved these changes
Sep 26, 2022
packages/react/select/src/Select.tsx
Outdated
Comment on lines
236
to
238
| // enable compatibility with native label or custom `Label` "click" | ||
| // this doesn't create any other side-effect because we are preventing default | ||
| // in `onPointerDown` so effectively this only runs for a label "click" |
There was a problem hiding this comment.
My memory is already failing but was this a Safari specific compatibility? if so should we be more explicit about that here?
There was a problem hiding this comment.
Yes that's correct, I'll add a mention of Safari.
Do we need to do any extra as relates to Slider given the now native label?
Given Label was never integrated with Slider yet, I was going to handle that in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1233