[Tooltip] Shouldn't open if trigger is clicked **before** the tooltip opens #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitgrelard
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Perfect, thanks for raising and fixing @AlbertoTonegari!
benoitgrelard
added a commit
to radix-ui/website
that referenced
this pull request
Sep 28, 2022
benoitgrelard
added a commit
to radix-ui/website
that referenced
this pull request
Sep 29, 2022
benoitgrelard
added a commit
to radix-ui/website
that referenced
this pull request
Sep 29, 2022
benoitgrelard
added a commit
to radix-ui/website
that referenced
this pull request
Oct 10, 2022
benoitgrelard
added a commit
to radix-ui/website
that referenced
this pull request
Oct 14, 2022
benoitgrelard
added a commit
to radix-ui/website
that referenced
this pull request
Oct 17, 2022
* Initial * Align release notes with latest changes (#468) * Update release notes * Create new toast page * Document onResume, onPause toast props * Document latest changes (#470) * Document latest changes * Update data/primitives/overview/releases.mdx Co-authored-by: Andy Hook <[email protected]> Co-authored-by: Andy Hook <[email protected]> * Add note regarding toast timer fix (#474) * Document latest Label changes (#475) * Document latest Label changes * Update copy * Apply suggestions from code review Co-authored-by: Andy Hook <[email protected]> Co-authored-by: Andy Hook <[email protected]> * Document 1693 changes (#478) radix-ui/primitives#1693 * Latest slider updates (#480) * Latest slider updates radix-ui/primitives#1695 * Update data/primitives/overview/releases.mdx Co-authored-by: Andy Hook <[email protected]> Co-authored-by: Andy Hook <[email protected]> * Add missing inverted prop to Slider (#482) * Document latest changes (#481) * Add selection improvement release note (#483) * Document Radio Group `disabled` prop (#484) * Create radio group file * Add note and prop docs addition * Add data-disabled attribute * Document latest slider changes (#489) * Document latest slider changes radix-ui/primitives#1696 * Update data/primitives/components/slider/1.1.0.mdx Co-authored-by: Andy Hook <[email protected]> Co-authored-by: Andy Hook <[email protected]> * [Select] Add `disabled` to API Reference (#488) * [Select] Create docs file * [Select] Add note and props addition * Document latest Select changes (#490) radix-ui/primitives#1598 * Update release note (#491) * Latest Slots updates (#492) * Latest Slots updates radix-ui/primitives#1713 * Fix typo * Document latest `DropdownMenu`/`ContextMenu` changes (`CheckboxItem` indeterminate) (#493) * Changelog * Duplicate files * Docs changes * PR feedback * Document `NavigationMenu` delay props (#495) * Add version page * Documentation changes * Update release filenames and breaking demo changes (#497) * Tweak release note, add date * Rename patch pages * Rename remaining patched packages * Bump files / versions * Fix build Co-authored-by: Benoît Grélard <[email protected]> Co-authored-by: Faqih Muntashir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1691
What was done?
Cancel the trigger event onClick.
More details?
The tooltip appears if the user stays hovered over the trigger component, but if the user clicks the trigger before the timeout activates the tooltip(which by default is 700ms), then the tooltip text no longer appears.
Screen.Recording.2022-09-28.at.4.52.17.PM.mov