Skip to content

[Collapsible][Accordion] Fix initial animation playback in Firefox and Safari #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

andy-hook
Copy link
Contributor

closes #1265

After some exploration it dawned that perhaps these browsers need a little bump to replay the animation from scratch for the initial size retrieval.

I'll try and validate this behaviour in a smaller example but this does fix the issue.

@benoitgrelard Do you remember why we moved away from the clearing the shorthand in the first place? I remember that had problems but i'm questioning if removing the name property alone is all we need.

@benoitgrelard
Copy link
Contributor

@benoitgrelard Do you remember why we moved away from the clearing the shorthand in the first place? I remember that had problems but i'm questioning if removing the name property alone is all we need.

It seems because we had the issue in #1040 so maybe run that scenario and see if your new change creates that regression?

Copy link
Contributor

@benoitgrelard benoitgrelard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending check in other comment 👍

@andy-hook
Copy link
Contributor Author

maybe run that scenario and see if your new change creates that regression

Looks good.

i'm questioning if removing the name property alone is all we need.

Tested in all browsers + IOS and still looks good, let me know if you're good with this additional change.

Copy link
Contributor

@benoitgrelard benoitgrelard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we could add some cypress tests or chromatic tests to test all these behaviours, although not sure how feasible that is given the tight criterias with animation.

@andy-hook
Copy link
Contributor Author

I'm wondering if we could add some cypress tests or chromatic tests to test all these behaviours, although not sure how feasible that is given the tight criterias with animation.

This would be ideal though feasibility is definitely an issue given the real time nature. Browser differences make this even harder 😞

@andy-hook andy-hook merged commit c3277ca into main Oct 11, 2022
@andy-hook andy-hook deleted the fix-collapsible-animation branch October 11, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accordion] Initial animation missing in Firefox and Safari
2 participants