Skip to content

[Slot] Don't eagerly create callbacks #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 12, 2022
Merged

[Slot] Don't eagerly create callbacks #1713

merged 3 commits into from
Oct 12, 2022

Conversation

benoitgrelard
Copy link
Contributor

Closes #1702

@benoitgrelard benoitgrelard merged commit c2827e8 into main Oct 12, 2022
@benoitgrelard benoitgrelard deleted the 1702-slot-updates branch October 12, 2022 11:54
benoitgrelard added a commit to radix-ui/website that referenced this pull request Oct 12, 2022
benoitgrelard added a commit to radix-ui/website that referenced this pull request Oct 12, 2022
* Latest Slots updates

radix-ui/primitives#1713

* Fix typo
benoitgrelard added a commit to radix-ui/website that referenced this pull request Oct 14, 2022
* Latest Slots updates

radix-ui/primitives#1713

* Fix typo
benoitgrelard added a commit to radix-ui/website that referenced this pull request Oct 17, 2022
* Initial

* Align release notes with latest changes (#468)

* Update release notes

* Create new toast page

* Document onResume, onPause toast props

* Document latest changes (#470)

* Document latest changes

* Update data/primitives/overview/releases.mdx

Co-authored-by: Andy Hook <[email protected]>

Co-authored-by: Andy Hook <[email protected]>

* Add note regarding toast timer fix (#474)

* Document latest Label changes (#475)

* Document latest Label changes

* Update copy

* Apply suggestions from code review

Co-authored-by: Andy Hook <[email protected]>

Co-authored-by: Andy Hook <[email protected]>

* Document 1693 changes (#478)

radix-ui/primitives#1693

* Latest slider updates (#480)

* Latest slider updates

radix-ui/primitives#1695

* Update data/primitives/overview/releases.mdx

Co-authored-by: Andy Hook <[email protected]>

Co-authored-by: Andy Hook <[email protected]>

* Add missing inverted prop to Slider (#482)

* Document latest changes (#481)

* Add selection improvement release note (#483)

* Document Radio Group `disabled` prop (#484)

* Create radio group file

* Add note and prop docs addition

* Add data-disabled attribute

* Document latest slider changes (#489)

* Document latest slider changes

radix-ui/primitives#1696

* Update data/primitives/components/slider/1.1.0.mdx

Co-authored-by: Andy Hook <[email protected]>

Co-authored-by: Andy Hook <[email protected]>

* [Select] Add `disabled` to API Reference (#488)

* [Select] Create docs file

* [Select] Add note and props addition

* Document latest Select changes (#490)

radix-ui/primitives#1598

* Update release note (#491)

* Latest Slots updates (#492)

* Latest Slots updates

radix-ui/primitives#1713

* Fix typo

* Document latest `DropdownMenu`/`ContextMenu` changes (`CheckboxItem` indeterminate) (#493)

* Changelog

* Duplicate files

* Docs changes

* PR feedback

* Document `NavigationMenu` delay props (#495)

* Add version page

* Documentation changes

* Update release filenames and breaking demo changes (#497)

* Tweak release note, add date

* Rename patch pages

* Rename remaining patched packages

* Bump files / versions

* Fix build

Co-authored-by: Benoît Grélard <[email protected]>
Co-authored-by: Faqih Muntashir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Slot] Slot passes functions to it's children for onX handler properties, even when the onX handler is falsey
2 participants