[NavigationMenu] Add delayDuration and skipDelayDuration to Root
#1716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-hook
commented
Oct 13, 2022
Comment on lines
108
to
109
| delayDuration = 0, | ||
| skipDelayDuration = 0, |
There was a problem hiding this comment.
Avoiding breaking change by not disturbing the current behaviour
There was a problem hiding this comment.
I'm not sure it would be considered a breaking change, I'd rather we start with good defaults and put a note in the changelog.
There was a problem hiding this comment.
That's true, especially if these defaults are blanket improvements. I added these as discussed and fixed the issue we noticed.
benoitgrelard
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1457
supersedes #1478