[ContextMenu] Add "disabled" prop to Context Menu trigger #1746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
reviewed
Oct 29, 2022
added 3 commits
October 29, 2022 12:55
fix(contextmenu): allow native context menu to open when the context menu is disabled
fix(contextmenu): clear active long press when the components gets disabled
|
Would it be possible to add disabled conditions based on PointerDown's type/button? |
|
@benoitgrelard is there anything that we could do to move this forward? :) |
|
Hey @Andarist, it seems the original contributor hasn't followed up, so if you want to address the remaining feedback we can move it forward. |
|
Hi, @Andarist and @benoitgrelard! I have already made needed changes in the following commit. Let me know if we need to add anything else, I will check |
|
Oh sorry my bad! |
benoitgrelard
approved these changes
Dec 12, 2022
andy-hook
approved these changes
Dec 12, 2022
|
This has now been released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
disabledprop to<ContextMenu />triggerCloses #1745