[Popper] Consistently calculate logical alignments #1890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Floating UI automatically accounts for logical position for alignment:
https://floating-ui.com/docs/computeposition#placement
However, this is applied inconsistently in our code as the referenced
floatingnode does not received thedirattribute.Floating UI needs this attribute to invert correctly.
This change fixes an inconsistency with our logical alignment whereby using
dir="rtl"on our primitives is inconsistent when usingPortalwith defaults. In the portalled case unlessrtlis applied to thebody(or higher) this logical inversion will not happen.Old behaviour:
New behaviour:
