Skip to content

Remove primitive element types from Portal part #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2023
Merged

Remove primitive element types from Portal part #2178

merged 2 commits into from
May 31, 2023

Conversation

joaom00
Copy link
Contributor

@joaom00 joaom00 commented May 30, 2023

Removed primitive element types from Portal part in all primitives and added JSDoc to the container prop in the Portal utility

Fixes #1974

benoitgrelard
benoitgrelard reviewed May 31, 2023
View reviewed changes
@benoitgrelard benoitgrelard merged commit f873591 into radix-ui:main May 31, 2023
@joaom00 joaom00 deleted the portal-props branch June 13, 2023 02:11
This was referenced Sep 26, 2023
Closed
Closed
@shadcn shadcn mentioned this pull request Oct 3, 2023
Merged
@joaom00 joaom00 mentioned this pull request Oct 18, 2023
Closed
@idoros idoros mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitgrelard benoitgrelard benoitgrelard approved these changes

@andy-hook andy-hook Awaiting requested review from andy-hook

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Portal] Props interface should not include primitive element types
2 participants
@joaom00 @benoitgrelard