Limit focus retention to when the document body is the activeElement #2182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOM nodes may be removed from the tree without having focus. In this case, the mutationObserver is greedy and steals focus that it should not be managing. By ensuring the body is the activeElement, we avoid stealing focus when the removed node did not have focus to begin with.
benoitgrelard
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Hey @robbtraister, thanks for your contribution.
You are right, it was definitely a bit too eager. This is more explicit now and inline with the explanation above.
I have used an early return and removed the now unnecessary conditional too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DOM nodes may be removed from the tree without having focus. In this case, the mutationObserver is greedy and steals focus that it should not be managing. As described in the adjacent comment, when the focused node is removed, browser focus is assigned to the body. By ensuring the body is the activeElement, we avoid stealing focus when the removed node did not have focus to begin with.
Fixes #2180