Slottable: Improve displayName for easier debugging #3441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajworkos
reviewed
Apr 3, 2025
|
|
||
| SlotClone.displayName = 'SlotClone'; | ||
| SlotClone.displayName = `${ownerName}.SlotClone`; |
ajworkos
approved these changes
Apr 3, 2025
chaance
added a commit
that referenced
this pull request
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something that has bugged me for a while is how Radix components add a lot of noise to the component tree view in React dev tools. This largely has to do with our use of the
Slotcomponent, which results in a view that is hard to grok and makes it more annoying to debug with so many components just namedSlot.This PR introduces functions to create
SlotandSlottablecomponents with unique display names to make things a little less chaotic.In the future I'd like to propose eliminating internal usage of
Slotfor a functional approach to actually clean up the component tree as much as possible. This is an interim solution that avoids major refactoring.