Skip to content

[Dialog][AlertDialog] Fix regression #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2021
Merged

[Dialog][AlertDialog] Fix regression #403

merged 2 commits into from
Jan 25, 2021

Conversation

benoitgrelard
Copy link
Contributor

@benoitgrelard benoitgrelard commented Jan 25, 2021 •
edited
Loading

I've spotted a small regression with Dialog 0.0.2 (and therefore AlertDialog) (closing when tabbing even though focus is trapped).

It was introduced introduced after we made the changes in FocusScope to not cancel out focusout event.
We had made the necessary changes in Popover and Menu, etc (to preventDefault when trapFocus was true) but forgot to do it always in the case of Dialog because focus is always trapped.

@benoitgrelard benoitgrelard requested a review from jjenzz as a code owner January 25, 2021 00:33
jjenzz
jjenzz approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@jjenzz jjenzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benoitgrelard benoitgrelard merged commit 8af478a into main Jan 25, 2021
@benoitgrelard benoitgrelard deleted the dialog-alert-dialog-fix branch January 25, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjenzz jjenzz jjenzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoitgrelard @jjenzz