[Presence] Improve Presence perf
#465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f66ce2 to
c706220
Compare
c706220 to
492e33f
Compare
2ff5469 to
6c9d2ca
Compare
benoitgrelard
approved these changes
Feb 22, 2021
Comment on lines
+12
to
+19
| export function useStateMachine<M>( | ||
| initialState: MachineState<M>, | ||
| machine: M & Machine<MachineState<M>> | ||
| ) { | ||
| return React.useReducer((state: MachineState<M>, event: MachineEvent<M>): MachineState<M> => { | ||
| const nextState = (machine[state] as any)[event]; | ||
| return nextState ?? state; | ||
| }, initialState); |
There was a problem hiding this comment.
| }; | ||
| }, [machine]); | ||
| // 🤯 https://fettblog.eu/typescript-union-to-intersection/ | ||
| type UnionToIntersection<T> = (T extends any ? (x: T) => any : never) extends (x: infer R) => any |
There was a problem hiding this comment.
I'm gonna still need some time to process this but I'll just do on my own time. I've played with it and it works very well! 👍
benoitgrelard
added a commit
that referenced
this pull request
Mar 3, 2021
# New features Breaking changes are indicated with a 🔥 icon. - Add support for SSR - [Accordion] Support multiple values (#527) 🔥 - [Tabs] Add RTL support (`dir` prop) (#497) - Remove `selector` prop and `data-radix-*` atributes 🔥 # Fixes - [Slider] Fix step rounding issue (#463) - [Presence] Improve `Presence` perf (#465) - Fixed potential issue with overriding attributes in certain primitives # Maintenance - Improved internal context handling - Better package/dependency split
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Easier to review with hidden whitespace changes.
We had report of some perf issues with nested
Collapsibles and I realisedPresencewas causing some problems there.I've prevented some
useEffectlogic from running unnecessarily on mount and removed@xstate/fsm.I had noticed that
@xstate/fsmreally eagerly re-renders components during my Carousel work so we can probably do without that and the additional bundle size it adds for such a simple machine here.These changes managed to double the speed in my tests.