[Accordion] Support multiple values #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jjenzz
commented
Mar 2, 2021
- Adds support for multiple values
- Toggles items by default (clicking button again will close item)
- To prevent items from closing, consumer now needs to control it
- Updates tests
- Updates stories
9082dc8 to
e199b5f
Compare
e199b5f to
5410542
Compare
jjenzz
commented
Mar 2, 2021
| const handleItemClose = React.useCallback( | ||
| (itemValue) => setValue((prevValue = []) => prevValue.filter((value) => value !== itemValue)), | ||
| [setValue] | ||
| ); |
There was a problem hiding this comment.
I thought this was a nice example of why it's good to have the callback implementation in the component that provides the context. I have the same context API provided by AccordionSingle and AccordionMultiple but they have different handler implementations 👍
jjenzz
commented
Mar 2, 2021
jjenzz
commented
Mar 2, 2021
Co-authored-by: Benoît Grélard <[email protected]>
benoitgrelard
approved these changes
Mar 3, 2021
benoitgrelard
added a commit
that referenced
this pull request
Mar 3, 2021
# New features Breaking changes are indicated with a 🔥 icon. - Add support for SSR - [Accordion] Support multiple values (#527) 🔥 - [Tabs] Add RTL support (`dir` prop) (#497) - Remove `selector` prop and `data-radix-*` atributes 🔥 # Fixes - [Slider] Fix step rounding issue (#463) - [Presence] Improve `Presence` perf (#465) - Fixed potential issue with overriding attributes in certain primitives # Maintenance - Improved internal context handling - Better package/dependency split
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.