Skip to content

[Primitive] Add defaultProps support to extendPrimitive #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 5, 2021
Merged

[Primitive] Add defaultProps support to extendPrimitive #539

merged 4 commits into from
Mar 5, 2021

Conversation

jjenzz
Copy link
Contributor

@jjenzz jjenzz commented Mar 5, 2021

Description

Adds support for defaultProps to extendPrimitive.

The plan is that with this change we could document this so that consumers can avoid the re-wrapping of types and React.forwardRef dance when all the need is to add a className or data attribute.

@jjenzz jjenzz requested a review from benoitgrelard as a code owner March 5, 2021 15:28
@jjenzz jjenzz force-pushed the extend-primitive branch from 048bdb3 to bc0764a Compare March 5, 2021 15:30
@benoitgrelard benoitgrelard merged commit 2b4a2f9 into main Mar 5, 2021
@benoitgrelard benoitgrelard deleted the extend-primitive branch March 5, 2021 16:50
benoitgrelard added a commit that referenced this pull request Mar 5, 2021
@benoitgrelard
New release
7427f47 
- [Presence][Collapsible][Accordion] Add height CSS property, remove transition support from Presence (#537)
- Fix potential type definition conflicts (#538)
- [Primitive] Add `defaultProps` support to `extendPrimitive` (#539)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitgrelard benoitgrelard benoitgrelard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjenzz @benoitgrelard