[Polymorphic] Narrow with React.ComponentType instead

[jjenzz]

Fixes #647

Replaces React.JSXElementConstructor with React.ComponentType to allow components typed by external libs in the as prop.

You can see the example from the issue working with this code here https://codesandbox.io/s/admiring-kalam-k2ltk?file=/src/App.tsx

[benoitgrelard]

The change looks fine, obviously a 1 liner, but for my knowledge, what's the difference between JSXElementConstructor and ComponentType?

[jjenzz]

ComponentType is FunctionComponent | ComponentClass and they have a more complex shape with static properties on them like displayName, propTypes, defaultProps etc.

I'm guessing TS needs this additional information to be able to narrow correctly. I didn't look into it too much as I had originally wanted to use React.ComponentType anyway. I didn't previously because of an issue with inline as components but we no longer have that issue since moving everything into one overload so this works well.

[benoitgrelard]

Ha sounds awesome then!

[Kerumen]

@jjenzz Thanks for the fix! Is it possible to release it on npm?

[benoitgrelard]

We will be doing a release once #682 is merged.