Fix onPointerDownOutside event issues 🔥
#654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onPointerDownOutside event issuesonPointerDownOutside event issues 🔥
benoitgrelard
commented
May 18, 2021
benoitgrelard
commented
May 18, 2021
jjenzz
suggested changes
May 19, 2021
jjenzz
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #646
This is a prequel to the modality changes as I bumped into that issue first hand when trying to make a dialog non-modal trying to focus something outside it by calling
event.preventDefaultinonInteractOutside.🔥 This change affects the event signature of
onPointerDownOutsideand/oronInteractOutsidefor the given components and therefore will need docs updates:AlertDialogContextMenuDialogDropdownMenuPopover