Skip to content

[Slider] Prevent form change event on initial render #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 1, 2021
Merged

[Slider] Prevent form change event on initial render #678

merged 4 commits into from
Jun 1, 2021

Conversation

jjenzz
Copy link
Contributor

@jjenzz jjenzz commented Jun 1, 2021

  • Adds usePrevious to prevent BubbleInput from bubbling change on initial render
  • Adds an isFormControl check to Slider and Checkbox so that BubbleInput only renders if these controls are used in forms
  • Added stories to show form change event working (multiple thumb version was strangely satisfying to play with 😄 ).
CleanShot.2021-06-01.at.14.00.38.mp4

@jjenzz jjenzz changed the title [Slider] Prevent form change event from firing when Slider initially renders [Slider] Prevent form change event on initial render Jun 1, 2021
jjenzz
jjenzz commented Jun 1, 2021
View reviewed changes
jjenzz
jjenzz commented Jun 1, 2021
View reviewed changes
jjenzz
jjenzz commented Jun 1, 2021
View reviewed changes
jjenzz
jjenzz commented Jun 1, 2021
View reviewed changes
jjenzz
jjenzz commented Jun 1, 2021
View reviewed changes
benoitgrelard
benoitgrelard reviewed Jun 1, 2021
View reviewed changes
@jjenzz jjenzz force-pushed the slider-fix branch 2 times, most recently from 4c194a7 to 9275c18 Compare June 1, 2021 16:15
@benoitgrelard benoitgrelard merged commit 3334012 into main Jun 1, 2021
@benoitgrelard benoitgrelard deleted the slider-fix branch June 1, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitgrelard benoitgrelard benoitgrelard approved these changes

@andy-hook andy-hook Awaiting requested review from andy-hook

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjenzz @benoitgrelard