[Dialog][AlertDialog][Popover][DropdownMenu][ContextMenu] Modality #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9e6ea31 to
41d2762
Compare
a038637 to
3d86bd8
Compare
jjenzz
reviewed
Jul 13, 2021
|
@andy-hook this PR is now fully complete right? Just a note that I'd like to review and test this in it's entirety one last time before we merge. Also, is it up to date with |
|
I assumed it is ready because of that ☝️ Sorry if I jumped the gun with my |
Yessir. Sounds sensible.
Not at all, that was my intention when I marked it. |
* [FocusScope] Update API for modality changes * Address PR feedback * PR feedback
* [Dialog] Add support for non-modal dialogs * PR feedback
* [AlertDialog] Don't compose onPointerDownOutside * Code style
* [Popover] Add support for modality * Modality scroll behaviour, default to non modal * Adjust for focus close in chromatic stories * Fix toggle when closing non modal * [Dialog][Popover] Update interact description
* [Menu] Support modality * [DropdownMenu] Expose modality * [ContextMenu] Expose modality * [DropdownMenu] `mouseDown` -> `pointerDown` * [Menu] disableOutsidePointerEvents only when open
* Explicit trigger focus * Simplify handling where possible * Code style, remove redundant check * [Popover] Revert `onEscapeKeyDown` default check
…cus behaviour (#799) * Adjust non-modal auto focus behaviour * Code style * Explicitly handle ref clearing * Refine ref clearing * Simplify handler composition in non-modal * Feedback * Revert auto focus cancellation * Improve focus handling readability * [ContextMenu] Adjust non-modal focus handling
benoitgrelard
commented
Jul 30, 2021
jjenzz
reviewed
Jul 30, 2021
jjenzz
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #585
Closes #566
This PR adds modality support to menus, dialogs and popovers. Originally we exposed a very granular api for managing pointer events, scroll locks and focus control. The most common use case for these props was to apply differing levels of modality depending on consumer needs.
By consolidating and streamlining these into a single
modalprop we are able to reduce the api surface while making the outcome easier and faster to achieve. This change also allows us to provide consistent handling across components and improve some additional handling under the hood.Example (DropdownMenu)
CleanShot.2021-07-13.at.15.00.23.mp4