[DropdownMenu] Remove ArrowUp to open 🔥
#702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArrowUp to openArrowUp to open 🔥
andy-hook
approved these changes
Jun 10, 2021
benoitgrelard
approved these changes
Jun 10, 2021
benoitgrelard
added a commit
that referenced
this pull request
Jun 15, 2021
* [Menu] Add submenu primitives (#627) Co-authored-by: Jenna Smith <[email protected]> * [Menu] Provide predictable typeahead scoping (#662) * Scope typeahead via collection * Exclude only on typeahead space key * Simplify typeahead * Prevent continuous `updateSearch` call * Inline `onExclusiveKeyDown` functionality * Clear search buffer when leaving * Move `MenuSubTrigger` code below `MenuContent` * `isTypingAhead` conditional clarity * [ContextMenu][DropdownMenu] Integrate new submenu parts (#629) * [ContextMenu][DropdownMenu] Add `TriggerItem` part (#683) * [ContextMenu][DropdownMenu] Don't close on sub trigger pointer down (#684) Co-authored-by: Jenna Smith <[email protected]> * [ContextMenu][DropdownMenu] Add pointer grace for navigation to sub-menus (#688) * [ContextMenu][DropdownMenu] delay sub trigger open via pointer * Add pointer area grace * Use clientX/Y rather than pageX/Y because getBoundingClientRect doesn't include scroll * Update DropdownMenu.stories.tsx * feedback * onItemEnter * Update Menu.tsx * more explicit open timer ref * Remove content rect caching * Move MenuItemImpl down (#689) * [DropdownMenu] Add `aria-labelledby` to follow spec (#692) * Add `aria-labelledby` * Follow `aria-expanded` spec for submenu triggers * Updates based on feedback * Rename root context type * [ContextMenu] Bring inline with `DropdownMenu` changes (#693) * Remove `ArrowUp` to open (#702) * [DropdownMenu] Enable `onEntryFocus` for root menu (#694) * Focus first item when all content types open for keyboard users * Initial feedback addressed * Add `pointerdown` to keyboard user logic * Remove capture * Re-apply capture events with comment * [ContextMenu][DropdownMenu] Improve pointer grace (#691) * Share grace timer ref in content * Align pointer behaviour closer with native * Simplify base story for easier test * Remove export of private func * Tidy from feedback * Minor naming adjustment * Apply `useCallback` Co-authored-by: Andy Hook <[email protected]> * [ContextMenu][DropdownMenu] Fix menu focus after pointer interaction (#707) * Fix menu focus after pointer interaction * Add explainer * [Menu] Remove `onPointerDownOutside` on sub (#708) * [ContextMenu][DropdownMenu] Improve touch/mouse handling separation (#709) * [ContextMenu][DropdownMenu] Improve touch/mouse handling separation * Feedback * [DropdownMenu][ContextMenu] Unwind all nested menus with ESC * [Menu] Tidy `handleSelect` binding * [Menu] Remove callbackRef in handleSelect * [Menu] onSelect optional chain Co-authored-by: Jenna Smith <[email protected]> Co-authored-by: Benoît Grélard <[email protected]> Co-authored-by: Jenna Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change sparked by this initial discussion #694 (comment)
Until we add logic to focus the last item on open then opening with
ArrowUpis not accessible. It also isn't required WAI-ARIA keyboard support so we're removing for now until we can handle this more appropriately.ArrowUpdocs.